exception - Java application randomly errors with: java.util.ConcurrentModificationException -

-

this question has answer here:

so i'm trying create simple gravity using lwjgl, application randomly crashes java.util.concurrentmodificationexceptionexception. strange thing is not happen @ same time. crashes instantly other times runs fine 10 minutes before crashing.

main game class:

public static arraylist<block> blocks;  public game() {     blocks = new arraylist<block>();      for(int = 0; < 40; i++)         blocks.add(new blocktest(i, 21, new float[] {0.4f, 0.6f, 0.7f}, false, 0));      spawntimer.scheduleatfixedrate(new timertask() {           public void run() {               spawnblock();           }     }, 1000, 1000); } public void update() {     for(block b : blocks)         b.update(); }

block class:

/** update block */ public void update() {     if(hasgravity) {         boolean colliding = false;          for(block b : game.blocks)             if(b.getblockid() == 0) {                 if(util.checkblockcollision(this, b)) {                     colliding = true;                     setblockid(0);                 }             }          if(falldelay.over() && !colliding) {             setblockyposwithoutblocksize(y += 2);             falldelay.start();         }     } }

the stack trace following:

exception in thread "main" java.util.concurrentmodificationexception     @ java.util.arraylist$itr.checkforcomodification(unknown source)     @ java.util.arraylist$itr.next(unknown source)     @ snakybo.gravitytest.block.block.update(block.java:26)     @ snakybo.gravitytest.game.update(game.java:34)     @ main.gameloop(main.java:52)     @ main.main(main.java:21)

with (game.java:34) being line:

b.update();

and (block.java:26) being:

for(block b : game.blocks)

if need full code, it's available on github

you multithreading. timertask runs on separate thread.

what happens this: spawnblock method being called on timer task thread modifies blocks list(adds 1 list). on main thread, update method called, in code iterates on blocks list.

because block added blocks list during iteration(during spawnblock method execution on other thread), concurrentmodificationexception.

replacing "for(block b : blocks)" "for(block b : new arraylist(blocks))" simple not performant solution: since iterate on new copy, can modify original list as want.

a better solution start making methods synchronized or rethink design, wrapping blocks list in synchronized wrapper.


Comments

Post a Comment

Popular posts from this blog

c++ - Function signature as a function template parameter -

-
i'd use function signature template argument. works great classes, when try same trick function templates, msvc throws error: error c2768: 'func' : illegal use of explicit template arguments here's code: template <typename signature> void func(); template <typename r, typename a1> void func<r(a1)>(); what should make work? you cannot partially specialize function template, not supported language. can create partially specialized class template static member function, , possibly trampoline function instantiate class template , invoke static function. something this: namespace detail { template<typename signature> struct helper; template<typename r, typename a1> struct helper<r(a1)> { static void call() { // stuff r , a1... } }; } template<typename signature> void func() { detail::helper<signature>::call(); }
Read more

algorithm - What are some ways to combine a number of (potentially incompatible) sorted sub-sets of a total set into a (partial) ordering of the total set? -

-
i have sorting problem i'm pretty sure doesn't have canonical "answer" - has number of different approaches, each pros/cons. i'm interested in hearing different approaches. suppose bunch of people {p_i | i=1,...,m} ranking favorite ice cream flavors. in total there n different flavors, single person p_i ranks n_i << n flavors or familiar with. i'm interested in combining these sub-rankings plausible overall ranking of n flavors. for concrete situation: m , n both 1000 (by coincidence), , each n_i 20 . can assume there's enough overlap in flavors people rank such no flavor "isolated". again, i'm interested in hearing different ways approach this, if there isn't single clear answer. thanks! one way approach problem construct directed cyclic graph representing of constraints on ordering of elements. nodes in graph represent different elements compared , have edge first node second node if had ranked first e...
Read more

How to call a javascript function after the page loads with a chrome extension? -

-
there's function on page want call after loads. not own page, can't insert html it. can please provide specific examples how chrome extension or greasemonkey? (function submitaction() ). both chrome extensions , greasemonkey offer ways specify when script inject if executed. in chrome extension, you set in manifest : "content_scripts": [ { "run_at" : "document_idle", in greasemonkey compatible userscripts, set in metadata // @run-at document-end in both cases, have add script if want ensure resources loaded when function executed : document.addeventlistener('load', submitaction);
Read more