c++ - Access violation error when getting input from a binary file -

-

okay, i'm trying read input binary file. i've changed code bit, version, i'm getting access violation error... it's trying access isn't there. here's source code problem area:

void hashfile::filedump (ostream &log) {     hashnode *temp = new hashnode;      fstream bin_file;     bin_file.open ("storage_file.bin", ios::in | ios::binary);        for(int = 0; < table_size; i++)     {         bin_file.seekg( * sizeof(hashnode) );          bin_file.read( (char *)&temp, sizeof(hashnode) );          printdump(hashnode(temp->title, temp->artist, temp->type, temp->year,         temp->price), log, i);     }      bin_file.close(); }  void hashfile::printdump(hashnode a, ostream &log, int n) {     log << "(" << n << ") " << a.title << ", " << a.artist         << ", " << a.type << ", " << a.year << ", $"         << setprecision(2) << a.price << endl; }

i know should have kind of error checking. right error occurring in printdump function. whenever try output log access violation error. however, change log cout , code run fine somewhat. read binary file i've created correctly until gets last element. i've been testing with, table_size should equal 5. loop , incremented until reaches 5 , keeps going. table_size being changed random value though haven't physically touched it. somehow writing on table_size's address in memory?

here definition of node:

class hashnode {     public:         hashnode();         ~hashnode();         hashnode(string title, string artist, string type, int year, float price);         friend class hashfile;     private:         char title [35];         char artist [25];         char type [12];         int year;         float price; };

this

bin_file.read( (char *)&temp, sizeof(hashnode) );

should this

bin_file.read( (char *)temp, sizeof(hashnode) );

you getting confused on pointers.

whether code work depends on definition of node haven't shown.

also code leaks memory temp never deleted. better not allocate temp @ all, this

void hashfile::filedump (ostream &log) {     hashnode temp;      fstream bin_file("storage_file.bin", ios::in | ios::binary);        for(int = 0; < table_size; i++)     {         bin_file.seekg( * sizeof(hashnode) );          bin_file.read( (char *)&temp, sizeof(hashnode) );          printdump(hashnode(temp.title, temp.artist, temp.type, temp.year, temp.price), log, i);     } }

not clear why feel need create new node temp, why not pass temp printdump? this

        printdump(temp, log, i);

but without seeing definition of node can't sure.

also no need close file, happens automatically, opening file in constructor little cleaner imho.

edit

ok having seen definition of node recommendation

void hashfile::filedump(ostream &log) {     fstream bin_file("storage_file.bin", ios::in | ios::binary);       for(int = 0; < table_size; i++)     {         bin_file.seekg(i * sizeof(hashnode));             hashnode temp;         bin_file.read((char *)&temp, sizeof(hashnode));         printdump(temp, log, i);     } }

also change printdump use const reference, avoids copying node object (it quite big).

void hashfile::printdump(const hashnode& a, ostream &log, int n) {     log << "(" << n << ") " << a.title << ", " << a.artist         << ", " << a.type << ", " << a.year << ", $"         << setprecision(2) << a.price << endl; }

Comments

Post a Comment

Popular posts from this blog

c++ - Function signature as a function template parameter -

-
i'd use function signature template argument. works great classes, when try same trick function templates, msvc throws error: error c2768: 'func' : illegal use of explicit template arguments here's code: template <typename signature> void func(); template <typename r, typename a1> void func<r(a1)>(); what should make work? you cannot partially specialize function template, not supported language. can create partially specialized class template static member function, , possibly trampoline function instantiate class template , invoke static function. something this: namespace detail { template<typename signature> struct helper; template<typename r, typename a1> struct helper<r(a1)> { static void call() { // stuff r , a1... } }; } template<typename signature> void func() { detail::helper<signature>::call(); }
Read more

algorithm - What are some ways to combine a number of (potentially incompatible) sorted sub-sets of a total set into a (partial) ordering of the total set? -

-
i have sorting problem i'm pretty sure doesn't have canonical "answer" - has number of different approaches, each pros/cons. i'm interested in hearing different approaches. suppose bunch of people {p_i | i=1,...,m} ranking favorite ice cream flavors. in total there n different flavors, single person p_i ranks n_i << n flavors or familiar with. i'm interested in combining these sub-rankings plausible overall ranking of n flavors. for concrete situation: m , n both 1000 (by coincidence), , each n_i 20 . can assume there's enough overlap in flavors people rank such no flavor "isolated". again, i'm interested in hearing different ways approach this, if there isn't single clear answer. thanks! one way approach problem construct directed cyclic graph representing of constraints on ordering of elements. nodes in graph represent different elements compared , have edge first node second node if had ranked first e...
Read more

How to call a javascript function after the page loads with a chrome extension? -

-
there's function on page want call after loads. not own page, can't insert html it. can please provide specific examples how chrome extension or greasemonkey? (function submitaction() ). both chrome extensions , greasemonkey offer ways specify when script inject if executed. in chrome extension, you set in manifest : "content_scripts": [ { "run_at" : "document_idle", in greasemonkey compatible userscripts, set in metadata // @run-at document-end in both cases, have add script if want ensure resources loaded when function executed : document.addeventlistener('load', submitaction);
Read more