java - Is there any way to refactor this code or re-write it in a compact form? -

-

i'm working on android app produces image effects on image. below snapshot of app:

as can see, on bottom - there horizontal scrollbar, , user touches 1 of images on horizontal scrollbar, same effect applied on above image.

i've total of 26 image effects , therefore 26 images in horizontal scrollbar. now, in code, i've find images , set onclicklistener()'s 1 particular listener.

i'm accomplishing task in following way:

    sepiagreenishimage      = (imageview) findviewbyid(r.id.sepiagreenish);     embossimage             = (imageview) findviewbyid(r.id.emboss);     sharpenimage            = (imageview) findviewbyid(r.id.sharpen);     slightyellowishimage    = (imageview) findviewbyid(r.id.ligth_yellow);     slightbluishimage       = (imageview) findviewbyid(r.id.light_blue);     slightreddishimage      = (imageview) findviewbyid(r.id.light_red);     slightgreenishimage     = (imageview) findviewbyid(r.id.light_green);     negativeimage           = (imageview) findviewbyid(r.id.negative);     greyscaleimage          = (imageview) findviewbyid(r.id.greyscale);     tintseventyimage        = (imageview) findviewbyid(r.id.tint_at_70);     tintthirtyimage         = (imageview) findviewbyid(r.id.tint_at_30);     snowimage               = (imageview) findviewbyid(r.id.snow);     darkimage               = (imageview) findviewbyid(r.id.darken);     noiseimage              = (imageview) findviewbyid(r.id.noise);     flipimage               = (imageview) findviewbyid(r.id.flip);     rotateimage             = (imageview) findviewbyid(r.id.rotate);     gaussianblurimage       = (imageview) findviewbyid(r.id.blur);     reddishimage            = (imageview) findviewbyid(r.id.reddish);     bluishimage             = (imageview) findviewbyid(r.id.bluish);     greenishimage           = (imageview) findviewbyid(r.id.greenish);     blackfilterimage        = (imageview) findviewbyid(r.id.black_filter);     increasedsepiaimage     = (imageview) findviewbyid(r.id.increased_sepia);     spiabluishimage         = (imageview) findviewbyid(r.id.sepia_bluish);     brightimage             = (imageview) findviewbyid(r.id.brighten);     mirrorimage             = (imageview) findviewbyid(r.id.mirror);

and following way, i'm setting onclicklistener:

    sepiagreenishimage.setonclicklistener(this);     embossimage.setonclicklistener(this);     sharpenimage.setonclicklistener(this);     slightyellowishimage.setonclicklistener(this);     slightbluishimage.setonclicklistener(this);     slightreddishimage.setonclicklistener(this);     slightgreenishimage.setonclicklistener(this);     negativeimage.setonclicklistener(this);     greyscaleimage.setonclicklistener(this);     tintseventyimage.setonclicklistener(this);     tintthirtyimage.setonclicklistener(this);     snowimage.setonclicklistener(this);     darkimage.setonclicklistener(this);     noiseimage.setonclicklistener(this);     flipimage.setonclicklistener(this);     rotateimage.setonclicklistener(this);     gaussianblurimage.setonclicklistener(this);     reddishimage.setonclicklistener(this);     bluishimage.setonclicklistener(this);     greenishimage.setonclicklistener(this);     blackfilterimage.setonclicklistener(this);     increasedsepiaimage.setonclicklistener(this);     spiabluishimage.setonclicklistener(this);     brightimage.setonclicklistener(this);     mirrorimage.setonclicklistener(this);

now, question how can apply kind of refactoring? because i'm repeating myself lot. kind of foreach loop or similar thing might me lot!

to programmatically, like:

viewgroup buttongroup = (viewgroup) findviewbyid(r.id.image_effect_buttons); (int = 0; < buttongroup.getchildcount(); i++) {     imageview imageview = (imageview) buttongroup.getchildat(i);     imageview.setonclicklistener(this); }

where "image_effect_buttons" id of whatever view (guessing linearlayout?) contains image buttons. note cause problems if viewgroup contains other children aside imageviews want attach listener to, it's simplest way avoid enumerating them explicitly.


Comments

Post a Comment

Popular posts from this blog

c++ - Function signature as a function template parameter -

-
i'd use function signature template argument. works great classes, when try same trick function templates, msvc throws error: error c2768: 'func' : illegal use of explicit template arguments here's code: template <typename signature> void func(); template <typename r, typename a1> void func<r(a1)>(); what should make work? you cannot partially specialize function template, not supported language. can create partially specialized class template static member function, , possibly trampoline function instantiate class template , invoke static function. something this: namespace detail { template<typename signature> struct helper; template<typename r, typename a1> struct helper<r(a1)> { static void call() { // stuff r , a1... } }; } template<typename signature> void func() { detail::helper<signature>::call(); }
Read more

algorithm - What are some ways to combine a number of (potentially incompatible) sorted sub-sets of a total set into a (partial) ordering of the total set? -

-
i have sorting problem i'm pretty sure doesn't have canonical "answer" - has number of different approaches, each pros/cons. i'm interested in hearing different approaches. suppose bunch of people {p_i | i=1,...,m} ranking favorite ice cream flavors. in total there n different flavors, single person p_i ranks n_i << n flavors or familiar with. i'm interested in combining these sub-rankings plausible overall ranking of n flavors. for concrete situation: m , n both 1000 (by coincidence), , each n_i 20 . can assume there's enough overlap in flavors people rank such no flavor "isolated". again, i'm interested in hearing different ways approach this, if there isn't single clear answer. thanks! one way approach problem construct directed cyclic graph representing of constraints on ordering of elements. nodes in graph represent different elements compared , have edge first node second node if had ranked first e...
Read more

How to call a javascript function after the page loads with a chrome extension? -

-
there's function on page want call after loads. not own page, can't insert html it. can please provide specific examples how chrome extension or greasemonkey? (function submitaction() ). both chrome extensions , greasemonkey offer ways specify when script inject if executed. in chrome extension, you set in manifest : "content_scripts": [ { "run_at" : "document_idle", in greasemonkey compatible userscripts, set in metadata // @run-at document-end in both cases, have add script if want ensure resources loaded when function executed : document.addeventlistener('load', submitaction);
Read more