java - Is there any way to refactor this code or re-write it in a compact form? -

-

i'm working on android app produces image effects on image. below snapshot of app:

as can see, on bottom - there horizontal scrollbar, , user touches 1 of images on horizontal scrollbar, same effect applied on above image.

i've total of 26 image effects , therefore 26 images in horizontal scrollbar. now, in code, i've find images , set onclicklistener()'s 1 particular listener.

i'm accomplishing task in following way:

    sepiagreenishimage      = (imageview) findviewbyid(r.id.sepiagreenish);     embossimage             = (imageview) findviewbyid(r.id.emboss);     sharpenimage            = (imageview) findviewbyid(r.id.sharpen);     slightyellowishimage    = (imageview) findviewbyid(r.id.ligth_yellow);     slightbluishimage       = (imageview) findviewbyid(r.id.light_blue);     slightreddishimage      = (imageview) findviewbyid(r.id.light_red);     slightgreenishimage     = (imageview) findviewbyid(r.id.light_green);     negativeimage           = (imageview) findviewbyid(r.id.negative);     greyscaleimage          = (imageview) findviewbyid(r.id.greyscale);     tintseventyimage        = (imageview) findviewbyid(r.id.tint_at_70);     tintthirtyimage         = (imageview) findviewbyid(r.id.tint_at_30);     snowimage               = (imageview) findviewbyid(r.id.snow);     darkimage               = (imageview) findviewbyid(r.id.darken);     noiseimage              = (imageview) findviewbyid(r.id.noise);     flipimage               = (imageview) findviewbyid(r.id.flip);     rotateimage             = (imageview) findviewbyid(r.id.rotate);     gaussianblurimage       = (imageview) findviewbyid(r.id.blur);     reddishimage            = (imageview) findviewbyid(r.id.reddish);     bluishimage             = (imageview) findviewbyid(r.id.bluish);     greenishimage           = (imageview) findviewbyid(r.id.greenish);     blackfilterimage        = (imageview) findviewbyid(r.id.black_filter);     increasedsepiaimage     = (imageview) findviewbyid(r.id.increased_sepia);     spiabluishimage         = (imageview) findviewbyid(r.id.sepia_bluish);     brightimage             = (imageview) findviewbyid(r.id.brighten);     mirrorimage             = (imageview) findviewbyid(r.id.mirror);

and following way, i'm setting onclicklistener:

    sepiagreenishimage.setonclicklistener(this);     embossimage.setonclicklistener(this);     sharpenimage.setonclicklistener(this);     slightyellowishimage.setonclicklistener(this);     slightbluishimage.setonclicklistener(this);     slightreddishimage.setonclicklistener(this);     slightgreenishimage.setonclicklistener(this);     negativeimage.setonclicklistener(this);     greyscaleimage.setonclicklistener(this);     tintseventyimage.setonclicklistener(this);     tintthirtyimage.setonclicklistener(this);     snowimage.setonclicklistener(this);     darkimage.setonclicklistener(this);     noiseimage.setonclicklistener(this);     flipimage.setonclicklistener(this);     rotateimage.setonclicklistener(this);     gaussianblurimage.setonclicklistener(this);     reddishimage.setonclicklistener(this);     bluishimage.setonclicklistener(this);     greenishimage.setonclicklistener(this);     blackfilterimage.setonclicklistener(this);     increasedsepiaimage.setonclicklistener(this);     spiabluishimage.setonclicklistener(this);     brightimage.setonclicklistener(this);     mirrorimage.setonclicklistener(this);

now, question how can apply kind of refactoring? because i'm repeating myself lot. kind of foreach loop or similar thing might me lot!

to programmatically, like:

viewgroup buttongroup = (viewgroup) findviewbyid(r.id.image_effect_buttons); (int = 0; < buttongroup.getchildcount(); i++) {     imageview imageview = (imageview) buttongroup.getchildat(i);     imageview.setonclicklistener(this); }

where "image_effect_buttons" id of whatever view (guessing linearlayout?) contains image buttons. note cause problems if viewgroup contains other children aside imageviews want attach listener to, it's simplest way avoid enumerating them explicitly.


Comments

Post a Comment

Popular posts from this blog

Perl - how to grep a block of text from a file -

-
it can in xml or text format. how in general grep block of text in perl? <track type="ws"> <range> <rangestart>0</rangestart> <rangeend>146.912</rangeend> <locationindex>0</locationindex> <propertyindex>0</propertyindex> </range> </track> <track type="ps" id="1"> <range> <rangestart>0</rangestart> <rangeend>146.912</rangeend> <locationindex>1</locationindex> <propertyindex>1</propertyindex> </range> </track> i want grep type="ps" , till </range> . one solution open file, read line line , match block. open(fh, "file.txt"); foreach $line (<fh>) { if ($line =~ m/type="cc"(.*?)<\/range>/) { print $1; } } but there more optimal solution without reading file line l
Read more

delphi - How to remove all the grips on a coolbar if I have several coolbands? -

-
Image
if set mycoolbar.fixedorder true,only grip on first band hidden. well,if use delphi 7 create vcl forms application,then put coolbar on , create 3 coolbans hold other controls,only grip , top coolbands can hidden setting mycoolbar.fixedorder:=true. i've uploaded picture make things clear. you got fixedorder property wrong. fixed property not allow bands rearranged if set true . setting property of coolbar true keep user changing bands order @ runtime, user can still move , resize bands. can give advice can do, actual solution problem, well, have wait answer. my advice use 3 coolbars in row , setting "fixedorder" property true , bandborderstyle bsnone . way grip hidden on of them. about property, it's not bug of ide, actual preference of property.
Read more

javascript - Animating array of divs; only the final element is modified -

-
this baffling me @ moment. i'm experienced programmer looking throw bit of surprise fiancee on countdown page our wedding. desired effect simulated confetti falling behind main page. setup follows: i have array of divs in javascript. each div absolutely positioned on page. have interval set updates every 50 or milliseconds. on each tick, run loop on array of divs, , calculations , update positions. problem problem having, however, though can see divs created, stored array, , modified (in case, each has slight randomized rotation) during initialization phase, once tick update position starts, div stored in whatever last slot of array gets position updated. tried hard-coding each div index testing purposes, strictly last element update position. upon printing current "left" , "top" style values each div before , after calculations shows value has been changed, no visible change noticeable. here's basic code: javascript var container;
Read more